From 26f5c56ba40e3dda71f3d4cf2f5eb3b09331af34 Mon Sep 17 00:00:00 2001 From: dgtlmoon Date: Mon, 1 Aug 2022 14:47:00 +0200 Subject: [PATCH] Remove [save & preview] button, the preview is not updated live so it can lead to confusion (#801) --- changedetectionio/__init__.py | 10 +++------- changedetectionio/forms.py | 2 +- changedetectionio/templates/edit.html | 4 +--- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/changedetectionio/__init__.py b/changedetectionio/__init__.py index acb301b5..ed7f26e2 100644 --- a/changedetectionio/__init__.py +++ b/changedetectionio/__init__.py @@ -634,14 +634,10 @@ def changedetection_app(config=None, datastore_o=None): update_q.put((1, uuid)) # Diff page [edit] link should go back to diff page - if request.args.get("next") and request.args.get("next") == 'diff' and not form.save_and_preview_button.data: + if request.args.get("next") and request.args.get("next") == 'diff': return redirect(url_for('diff_history_page', uuid=uuid)) - else: - if form.save_and_preview_button.data: - flash('You may need to reload this page to see the new content.') - return redirect(url_for('preview_page', uuid=uuid)) - else: - return redirect(url_for('index')) + + return redirect(url_for('index')) else: if request.method == 'POST' and not form.validate(): diff --git a/changedetectionio/forms.py b/changedetectionio/forms.py index 7a307a5b..b8ca6695 100644 --- a/changedetectionio/forms.py +++ b/changedetectionio/forms.py @@ -350,7 +350,7 @@ class watchForm(commonSettingsForm): webdriver_js_execute_code = TextAreaField('Execute JavaScript before change detection', render_kw={"rows": "5"}, validators=[validators.Optional()]) save_button = SubmitField('Save', render_kw={"class": "pure-button pure-button-primary"}) - save_and_preview_button = SubmitField('Save & Preview', render_kw={"class": "pure-button pure-button-primary"}) + proxy = RadioField('Proxy') filter_failure_notification_send = BooleanField( 'Send a notification when the filter can no longer be found on the page', default=False) diff --git a/changedetectionio/templates/edit.html b/changedetectionio/templates/edit.html index c26ed475..2bf94352 100644 --- a/changedetectionio/templates/edit.html +++ b/changedetectionio/templates/edit.html @@ -307,9 +307,7 @@ Unavailable") }}
- - {{ render_button(form.save_button) }} {{ render_button(form.save_and_preview_button) }} - + {{ render_button(form.save_button) }} Delete