From 6562d6e0d4745c28855a99bb5d28c48885225398 Mon Sep 17 00:00:00 2001 From: dgtlmoon Date: Tue, 13 Dec 2022 12:28:20 +0100 Subject: [PATCH] Improve ARM/rust build comment --- Dockerfile | 5 ++--- requirements.txt | 5 +++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Dockerfile b/Dockerfile index 6b067afe..b13ce427 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,7 +1,7 @@ # pip dependencies install stage FROM python:3.8-slim as builder -# rustc compiler would be needed on ARM type devices but theres an issue with some deps not building.. +# See `cryptography` pin comment in requirements.txt ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1 RUN apt-get update && apt-get install -y --no-install-recommends \ @@ -31,8 +31,7 @@ RUN pip install --target=/dependencies playwright~=1.27.1 \ # Final image stage FROM python:3.8-slim -# Actual packages needed at runtime, usually due to the notification (apprise) backend -# rustc compiler would be needed on ARM type devices but theres an issue with some deps not building.. +# See `cryptography` pin comment in requirements.txt ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1 # Re #93, #73, excluding rustc (adds another 430Mb~) diff --git a/requirements.txt b/requirements.txt index 70eb4208..dbc9837f 100644 --- a/requirements.txt +++ b/requirements.txt @@ -29,8 +29,9 @@ apprise~=1.2.0 # apprise mqtt https://github.com/dgtlmoon/changedetection.io/issues/315 paho-mqtt -# Pinned version of cryptography otherwise -# ERROR: Could not build wheels for cryptography which use PEP 517 and cannot be installed directly +# This mainly affects some ARM builds, which unlike the other builds ignores "ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1" +# so without this pinning, the newer versions on ARM will forcefully try to build rust, which results in "rust compiler not found" +# (introduced once apprise became a dep) cryptography~=3.4 # Used for CSS filtering