diff --git a/changedetectionio/__init__.py b/changedetectionio/__init__.py index 2b76f2d3..6d482879 100644 --- a/changedetectionio/__init__.py +++ b/changedetectionio/__init__.py @@ -1,5 +1,15 @@ #!/usr/bin/python3 +from changedetectionio import queuedWatchMetaData +from copy import deepcopy +from distutils.util import strtobool +from feedgen.feed import FeedGenerator +from flask_compress import Compress as FlaskCompress +from flask_login import current_user +from flask_restful import abort, Api +from flask_wtf import CSRFProtect +from functools import wraps +from threading import Event import datetime import flask_login import logging @@ -10,12 +20,6 @@ import threading import time import timeago -from changedetectionio import queuedWatchMetaData -from copy import deepcopy -from distutils.util import strtobool -from feedgen.feed import FeedGenerator -from threading import Event - from flask import ( Flask, abort, @@ -28,10 +32,6 @@ from flask import ( session, url_for, ) -from flask_compress import Compress as FlaskCompress -from flask_login import login_required -from flask_restful import abort, Api -from flask_wtf import CSRFProtect from changedetectionio import html_tools from changedetectionio.api import api_v1 @@ -65,8 +65,6 @@ app.config.exit = Event() app.config['NEW_VERSION_AVAILABLE'] = False -app.config['LOGIN_DISABLED'] = False - #app.config["EXPLAIN_TEMPLATE_LOADING"] = True # Disables caching of the templates @@ -148,7 +146,6 @@ class User(flask_login.UserMixin): # Compare given password against JSON store or Env var def check_password(self, password): - import base64 import hashlib @@ -156,11 +153,9 @@ class User(flask_login.UserMixin): raw_salt_pass = os.getenv("SALTED_PASS", False) if not raw_salt_pass: - raw_salt_pass = datastore.data['settings']['application']['password'] + raw_salt_pass = datastore.data['settings']['application'].get('password') raw_salt_pass = base64.b64decode(raw_salt_pass) - - salt_from_storage = raw_salt_pass[:32] # 32 is the length of the salt # Use the exact same setup you used to generate the key, but this time put in the password to check @@ -170,21 +165,50 @@ class User(flask_login.UserMixin): salt_from_storage, 100000 ) - new_key = salt_from_storage + new_key + new_key = salt_from_storage + new_key return new_key == raw_salt_pass pass +def login_optionally_required(func): + @wraps(func) + def decorated_view(*args, **kwargs): + has_password_enabled = datastore.data['settings']['application'].get('password') or os.getenv("SALTED_PASS", False) + if not has_password_enabled: + return func(*args, **kwargs) + + # Permitted + if request.endpoint == 'static_content' and request.view_args['group'] == 'styles': + return func(*args, **kwargs) + # Permitted + elif request.endpoint == 'diff_history_page' and datastore.data['settings']['application'].get('shared_diff_access'): + return func(*args, **kwargs) + # Permitted + elif request.endpoint == 'rss': + app_rss_token = datastore.data['settings']['application'].get('rss_access_token') + rss_url_token = request.args.get('token') + # Both not none and they are the same + if app_rss_token and rss_url_token and rss_url_token == app_rss_token: + return None + + elif request.method in flask_login.config.EXEMPT_METHODS: + return func(*args, **kwargs) + elif app.config.get('LOGIN_DISABLED'): + return func(*args, **kwargs) + elif not current_user.is_authenticated: + return app.login_manager.unauthorized() + return func(*args, **kwargs) + + return decorated_view + def changedetection_app(config=None, datastore_o=None): global datastore datastore = datastore_o # so far just for read-only via tests, but this will be moved eventually to be the main source # (instead of the global var) - app.config['DATASTORE']=datastore_o - - #app.config.update(config or {}) + app.config['DATASTORE'] = datastore_o login_manager = flask_login.LoginManager(app) login_manager.login_view = 'login' @@ -212,6 +236,8 @@ def changedetection_app(config=None, datastore_o=None): # https://flask-cors.readthedocs.io/en/latest/ # CORS(app) + + @login_manager.user_loader def user_loader(email): user = User() @@ -220,7 +246,7 @@ def changedetection_app(config=None, datastore_o=None): @login_manager.unauthorized_handler def unauthorized_handler(): - # @todo validate its a URL of this host and use that + flash("You must be logged in, please log in.", 'error') return redirect(url_for('login', next=url_for('index'))) @app.route('/logout') @@ -233,10 +259,6 @@ def changedetection_app(config=None, datastore_o=None): @app.route('/login', methods=['GET', 'POST']) def login(): - if not datastore.data['settings']['application']['password'] and not os.getenv("SALTED_PASS", False): - flash("Login not required, no password enabled.", "notice") - return redirect(url_for('index')) - if request.method == 'GET': if flask_login.current_user.is_authenticated: flash("Already logged in") @@ -271,29 +293,16 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('login')) @app.before_request - def do_something_whenever_a_request_comes_in(): - - # Disable password login if there is not one set - # (No password in settings or env var) - app.config['LOGIN_DISABLED'] = datastore.data['settings']['application']['password'] == False and os.getenv("SALTED_PASS", False) == False - + def before_request_handle_cookie_x_settings(): # Set the auth cookie path if we're running as X-settings/X-Forwarded-Prefix if os.getenv('USE_X_SETTINGS') and 'X-Forwarded-Prefix' in request.headers: app.config['REMEMBER_COOKIE_PATH'] = request.headers['X-Forwarded-Prefix'] app.config['SESSION_COOKIE_PATH'] = request.headers['X-Forwarded-Prefix'] - # For the RSS path, allow access via a token - if request.path == '/rss' and request.args.get('token'): - app_rss_token = datastore.data['settings']['application']['rss_access_token'] - rss_url_token = request.args.get('token') - if app_rss_token == rss_url_token: - app.config['LOGIN_DISABLED'] = True - - if request.path.startswith('/diff/') and datastore.data['settings']['application'].get('shared_diff_access'): - app.config['LOGIN_DISABLED'] = True + return None @app.route("/rss", methods=['GET']) - @login_required + @login_optionally_required def rss(): from . import diff limit_tag = request.args.get('tag') @@ -368,7 +377,7 @@ def changedetection_app(config=None, datastore_o=None): return response @app.route("/", methods=['GET']) - @login_required + @login_optionally_required def index(): from changedetectionio import forms @@ -432,7 +441,7 @@ def changedetection_app(config=None, datastore_o=None): # AJAX endpoint for sending a test @app.route("/notification/send-test", methods=['POST']) - @login_required + @login_optionally_required def ajax_callback_send_notification_test(): import apprise @@ -465,7 +474,7 @@ def changedetection_app(config=None, datastore_o=None): @app.route("/clear_history/", methods=['GET']) - @login_required + @login_optionally_required def clear_watch_history(uuid): try: datastore.clear_watch_history(uuid) @@ -477,7 +486,7 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('index')) @app.route("/clear_history", methods=['GET', 'POST']) - @login_required + @login_optionally_required def clear_all_history(): if request.method == 'POST': @@ -534,7 +543,7 @@ def changedetection_app(config=None, datastore_o=None): @app.route("/edit/", methods=['GET', 'POST']) - @login_required + @login_optionally_required # https://stackoverflow.com/questions/42984453/wtforms-populate-form-with-data-if-data-exists # https://wtforms.readthedocs.io/en/3.0.x/forms/#wtforms.form.Form.populate_obj ? @@ -680,7 +689,7 @@ def changedetection_app(config=None, datastore_o=None): return output @app.route("/settings", methods=['GET', "POST"]) - @login_required + @login_optionally_required def settings_page(): from changedetectionio import content_fetcher, forms @@ -760,7 +769,7 @@ def changedetection_app(config=None, datastore_o=None): return output @app.route("/import", methods=['GET', "POST"]) - @login_required + @login_optionally_required def import_page(): remaining_urls = [] if request.method == 'POST': @@ -798,7 +807,7 @@ def changedetection_app(config=None, datastore_o=None): # Clear all statuses, so we do not see the 'unviewed' class @app.route("/form/mark-all-viewed", methods=['GET']) - @login_required + @login_optionally_required def mark_all_viewed(): # Save the current newest history as the most recently viewed @@ -808,7 +817,7 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('index')) @app.route("/diff/", methods=['GET', 'POST']) - @login_required + @login_optionally_required def diff_history_page(uuid): from changedetectionio import forms @@ -915,7 +924,7 @@ def changedetection_app(config=None, datastore_o=None): return output @app.route("/preview/", methods=['GET']) - @login_required + @login_optionally_required def preview_page(uuid): content = [] ignored_line_numbers = [] @@ -1005,7 +1014,7 @@ def changedetection_app(config=None, datastore_o=None): return output @app.route("/settings/notification-logs", methods=['GET']) - @login_required + @login_optionally_required def notification_logs(): global notification_debug_log output = render_template("notification-log.html", @@ -1015,7 +1024,7 @@ def changedetection_app(config=None, datastore_o=None): # We're good but backups are even better! @app.route("/backup", methods=['GET']) - @login_required + @login_optionally_required def get_backup(): import zipfile @@ -1135,7 +1144,7 @@ def changedetection_app(config=None, datastore_o=None): abort(404) @app.route("/form/add/quickwatch", methods=['POST']) - @login_required + @login_optionally_required def form_quick_watch_add(): from changedetectionio import forms form = forms.quickWatchForm(request.form) @@ -1167,7 +1176,7 @@ def changedetection_app(config=None, datastore_o=None): @app.route("/api/delete", methods=['GET']) - @login_required + @login_optionally_required def form_delete(): uuid = request.args.get('uuid') @@ -1184,7 +1193,7 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('index')) @app.route("/api/clone", methods=['GET']) - @login_required + @login_optionally_required def form_clone(): uuid = request.args.get('uuid') # More for testing, possible to return the first/only @@ -1199,7 +1208,7 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('index')) @app.route("/api/checknow", methods=['GET']) - @login_required + @login_optionally_required def form_watch_checknow(): # Forced recheck will skip the 'skip if content is the same' rule (, 'reprocess_existing_data': True}))) tag = request.args.get('tag') @@ -1233,7 +1242,7 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('index', tag=tag)) @app.route("/form/checkbox-operations", methods=['POST']) - @login_required + @login_optionally_required def form_watch_list_checkbox_operations(): op = request.form['op'] uuids = request.form.getlist('uuids') @@ -1297,7 +1306,7 @@ def changedetection_app(config=None, datastore_o=None): return redirect(url_for('index')) @app.route("/api/share-url", methods=['GET']) - @login_required + @login_optionally_required def form_share_put_watch(): """Given a watch UUID, upload the info and return a share-link the share-link can be imported/added""" diff --git a/changedetectionio/blueprint/browser_steps/__init__.py b/changedetectionio/blueprint/browser_steps/__init__.py index 9087acac..d49af7a4 100644 --- a/changedetectionio/blueprint/browser_steps/__init__.py +++ b/changedetectionio/blueprint/browser_steps/__init__.py @@ -23,11 +23,10 @@ from distutils.util import strtobool from flask import Blueprint, request, make_response -from flask_login import login_required import os import logging from changedetectionio.store import ChangeDetectionStore - +from changedetectionio import login_optionally_required browsersteps_live_ui_o = {} browsersteps_playwright_browser_interface = None browsersteps_playwright_browser_interface_browser = None @@ -65,7 +64,7 @@ def construct_blueprint(datastore: ChangeDetectionStore): browser_steps_blueprint = Blueprint('browser_steps', __name__, template_folder="templates") - @login_required + @login_optionally_required @browser_steps_blueprint.route("/browsersteps_update", methods=['GET', 'POST']) def browsersteps_ui_update(): import base64