From e9c4037178130ef2285ac6e36e4599440e49565f Mon Sep 17 00:00:00 2001
From: dgtlmoon <dgtlmoon@gmail.com>
Date: Tue, 9 Jul 2024 15:07:23 +0200
Subject: [PATCH] UI - Visual Selector - Multiple selections (refactor) (#2475)

---
 .../static/js/visual-selector.js              | 31 +++++++++++++++----
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/changedetectionio/static/js/visual-selector.js b/changedetectionio/static/js/visual-selector.js
index 9cde7350..7cc54e86 100644
--- a/changedetectionio/static/js/visual-selector.js
+++ b/changedetectionio/static/js/visual-selector.js
@@ -36,10 +36,12 @@ $(document).ready(() => {
 
     function clearReset() {
         ctx.clearRect(0, 0, c.width, c.height);
+
         if ($includeFiltersElem.val().length) {
             alert("Existing filters under the 'Filters & Triggers' tab were cleared.");
         }
         $includeFiltersElem.val('');
+
         currentSelections = [];
 
         // Means we ignore the xpaths from the scraper marked as sel.highlight_as_custom_filter (it matched a previous selector)
@@ -109,6 +111,18 @@ $(document).ready(() => {
         $selectorBackgroundElem.attr('src', s);
     }
 
+    function alertIfFilterNotFound() {
+        let existingFilters = splitToList($includeFiltersElem.val());
+        let sizePosXpaths = selectorData['size_pos'].map(sel => sel.xpath);
+
+        for (let filter of existingFilters) {
+            if (!sizePosXpaths.includes(filter)) {
+                alert(`One or more of your existing filters was not found and will be removed when a new filter is selected.`);
+                break;
+            }
+        }
+    }
+
     function fetchData() {
         $fetchingUpdateNoticeElem.html("Fetching element data..");
 
@@ -119,7 +133,11 @@ $(document).ready(() => {
             $fetchingUpdateNoticeElem.html("Rendering..");
             selectorData = data;
             sortScrapedElementsBySize();
-            console.log("Reported browser width from backend: " + data['browser_width']);
+            console.log(`Reported browser width from backend: ${data['browser_width']}`);
+
+            // Little sanity check for the user, alert them if something missing
+            alertIfFilterNotFound();
+
             setScale();
             reflowSelector();
             $fetchingUpdateNoticeElem.fadeOut();
@@ -130,10 +148,11 @@ $(document).ready(() => {
         // Assuming currentSelections is already defined and contains the selections
         let uniqueSelections = new Set(currentSelections.map(sel => (sel[0] === '/' ? `xpath:${sel.xpath}` : sel.xpath)));
 
-        // Convert the Set back to an array and join with newline characters
-        let textboxFilterText = Array.from(uniqueSelections).join("\n");
-
-        $includeFiltersElem.val(textboxFilterText);
+        if (currentSelections.length > 0) {
+            // Convert the Set back to an array and join with newline characters
+            let textboxFilterText = Array.from(uniqueSelections).join("\n");
+            $includeFiltersElem.val(textboxFilterText);
+        }
     }
 
     function setScale() {
@@ -237,4 +256,4 @@ $(document).ready(() => {
             xctx.strokeRect(sel.left * xScale, sel.top * yScale, sel.width * xScale, sel.height * yScale);
         });
     }
-});
+});
\ No newline at end of file