From f00b8e4efbe9e75e83241954eccf8298ff5d0806 Mon Sep 17 00:00:00 2001
From: dgtlmoon <dgtlmoon@gmail.com>
Date: Tue, 3 Dec 2024 18:11:14 +0100
Subject: [PATCH] UI - Fixing scheduler options

---
 .../static/js/global-settings.js              | 11 +++--
 changedetectionio/static/js/scheduler.js      | 46 +++++++++++--------
 changedetectionio/templates/_helpers.html     |  2 +-
 3 files changed, 33 insertions(+), 26 deletions(-)

diff --git a/changedetectionio/static/js/global-settings.js b/changedetectionio/static/js/global-settings.js
index 2c573964..5ede2509 100644
--- a/changedetectionio/static/js/global-settings.js
+++ b/changedetectionio/static/js/global-settings.js
@@ -30,11 +30,12 @@ $(document).ready(function () {
     })
 
     const timezoneInput = $('#application-timezone');
-    const timezone = Intl.DateTimeFormat().resolvedOptions().timeZone;
-
-    if (!timezoneInput.val().trim()) {
-        timezoneInput.val(timezone);
-        timezoneInput.after('<div class="timezone-message">The timezone was set from your browser, <strong>be sure to press save!</strong></div>');
+    if(timezoneInput.length) {
+        const timezone = Intl.DateTimeFormat().resolvedOptions().timeZone;
+        if (!timezoneInput.val().trim()) {
+            timezoneInput.val(timezone);
+            timezoneInput.after('<div class="timezone-message">The timezone was set from your browser, <strong>be sure to press save!</strong></div>');
+        }
     }
 
 });
diff --git a/changedetectionio/static/js/scheduler.js b/changedetectionio/static/js/scheduler.js
index 76dd141d..d551fb45 100644
--- a/changedetectionio/static/js/scheduler.js
+++ b/changedetectionio/static/js/scheduler.js
@@ -24,16 +24,28 @@ $(document).ready(function () {
 
     toggleVisibility('#time_schedule_limit-enabled, #requests-time_schedule_limit-enabled', '#schedule-day-limits-wrapper', true)
 
+    setInterval(() => {
+        let success = true;
+        try {
+            // Show the current local time according to either placeholder or entered TZ name
+            if (timezone_text_widget.val().length) {
+                $('#local-time-in-tz').text(getTimeInTimezone(timezone_text_widget.val()));
+            } else {
+                // So maybe use what is in the placeholder (which will be the default settings)
+                $('#local-time-in-tz').text(getTimeInTimezone(timezone_text_widget.attr('placeholder')));
+            }
+        } catch (error) {
+            success = false;
+            $('#local-time-in-tz').text("");
+            console.error(timezone_text_widget.val())
+        }
+
+        $(timezone_text_widget).toggleClass('error', !success);
+
+    }, 500);
+
     $('#schedule-day-limits-wrapper').on('change click blur', 'input, checkbox, select', function() {
 
-        if (timezone_text_widget.val().length) {
-            document.getElementById('local-time-in-tz').textContent =
-                getTimeInTimezone(timezone_text_widget.val());
-        } else {
-            // So maybe use what is in the placeholder (which will be the default settings)
-            document.getElementById('local-time-in-tz').textContent =
-                getTimeInTimezone(timezone_text_widget.attr('placeholder'));
-        }
         let allOk = true;
 
         // Controls setting the warning that the time could overlap into the next day
@@ -63,14 +75,13 @@ $(document).ready(function () {
         });
 
         warning_text.toggle(!allOk)
-    }, 500);
+    });
 
     $('table[id*="time_schedule_limit-saturday"], table[id*="time_schedule_limit-sunday"]').addClass("weekend-day")
 
     // Presets [weekend] [business hours] etc
     $(document).on('click', '[data-template].set-schedule', function () {
         // Get the value of the 'data-template' attribute
-
         switch ($(this).attr('data-template')) {
             case 'business-hours':
                 $('.day-schedule table:not(.weekend-day) input[type="time"]').val('09:00')
@@ -87,16 +98,11 @@ $(document).ready(function () {
                 $('.day-schedule .weekend-day input[id*="-enabled"]').prop('checked', true);
                 break;
             case 'reset':
-                $('.day-schedule .day-schedule input[type="time"]').val('00:00')
-                $('.day-schedule .day-schedule select[id*="-duration-hours"]').val('24');
-                $('.day-schedule .day-schedule select[id*="-duration-minutes"]').val('0');
-                $('.day-schedule .day-schedule input[id*="-enabled"]').prop('checked', true);
-                break;
-            case 'once-per-day':
-                $('.day-schedule .day-schedule input[type="time"]').val('00:00')
-                $('.day-schedule .day-schedule select[id*="-duration-hours"]').val('24');
-                $('.day-schedule .day-schedule select[id*="-duration-minutes"]').val('0');
-                $('.day-schedule .day-schedule input[id*="-enabled"]').prop('checked', true);
+
+                $('.day-schedule input[type="time"]').val('00:00')
+                $('.day-schedule select[id*="-duration-hours"]').val('24');
+                $('.day-schedule select[id*="-duration-minutes"]').val('0');
+                $('.day-schedule input[id*="-enabled"]').prop('checked', true);
                 break;
         }
     });
diff --git a/changedetectionio/templates/_helpers.html b/changedetectionio/templates/_helpers.html
index a2099489..85fb5969 100644
--- a/changedetectionio/templates/_helpers.html
+++ b/changedetectionio/templates/_helpers.html
@@ -79,7 +79,7 @@
         padding-left: 0.5rem;
         padding-right: 0.5rem;
     }
-    #timespan-warning {
+    #timespan-warning, input[id*='time_schedule_limit-timezone'].error {
         color: #ff0000;
     }
     .day-schedule.warning table {