diff --git a/backend/__init__.py b/backend/__init__.py index 3a1c5708..a6439968 100644 --- a/backend/__init__.py +++ b/backend/__init__.py @@ -486,29 +486,10 @@ def changedetection_app(config=None, datastore_o=None): datastore.data['settings']['application']['notification_title'] = form.notification_title.data datastore.data['settings']['application']['notification_body'] = form.notification_body.data - if len(form.notification_urls.data): - import apprise - apobj = apprise.Apprise() - apobj.debug = True - - # Add each notification - for n in datastore.data['settings']['application']['notification_urls']: - apobj.add(n) - outcome = apobj.notify( - body='Hello from the worlds best and simplest web page change detection and monitoring service!', - title='Changedetection.io Notification Test', - ) - - if outcome: - flash("{} Notification URLs reached.".format(len(form.notification_urls.data)), "notice") - else: - flash("One or more Notification URLs failed", 'error') - - datastore.data['settings']['application']['notification_urls'] = form.notification_urls.data datastore.needs_write = True - if form.trigger_check.data: + if form.trigger_check.data and len(form.notification_urls.data): n_object = {'watch_url': "Test from changedetection.io!", 'notification_urls': form.notification_urls.data} notification_q.put(n_object) diff --git a/backend/templates/settings.html b/backend/templates/settings.html index f438e9fb..0df9ded1 100644 --- a/backend/templates/settings.html +++ b/backend/templates/settings.html @@ -86,11 +86,9 @@ SMTPS - mailtos://user:pass@mail.domain.com?to=receivingAddress@example.com") }} - - - - +
+ {{ render_field(form.trigger_check) }} +
diff --git a/backend/tests/test_notification.py b/backend/tests/test_notification.py index 83609804..2c39ed91 100644 --- a/backend/tests/test_notification.py +++ b/backend/tests/test_notification.py @@ -94,10 +94,13 @@ def test_check_notification(client, live_server): url_for("settings_page"), data={"notification_title": "New ChangeDetection.io Notification - {watch_url}", "notification_body": "{base_url}\n{watch_url}\n{preview_url}\n{diff_url}\n{current_snapshot}\n:-)", + "notification_urls": "json://foobar.com", #Re #143 should not see that it sent without [test checkbox] "minutes_between_check": 180}, follow_redirects=True ) assert b"Settings updated." in res.data + # Re #143 - should not see this if we didnt hit the test box + assert b"Notifications queued" not in res.data # Trigger a check client.get(url_for("api_watch_checknow"), follow_redirects=True)