From 2470451f6de333b15514d0e63ece558f17a519cd Mon Sep 17 00:00:00 2001 From: Louis Lam Date: Sat, 26 Oct 2024 20:47:38 +0800 Subject: [PATCH] Fix Apprise download issue (#5251) --- docker/debian-base.dockerfile | 15 +++++++-- extra/download-apprise.mjs | 57 +++++++++++++++++++++++++++++++++++ 2 files changed, 70 insertions(+), 2 deletions(-) create mode 100644 extra/download-apprise.mjs diff --git a/docker/debian-base.dockerfile b/docker/debian-base.dockerfile index 80550412..a1717437 100644 --- a/docker/debian-base.dockerfile +++ b/docker/debian-base.dockerfile @@ -1,3 +1,13 @@ +# Download Apprise deb package +FROM node:20-bookworm-slim AS download-apprise +WORKDIR /app +COPY ./extra/download-apprise.mjs ./download-apprise.mjs +RUN apt update && \ + apt --yes --no-install-recommends install curl && \ + npm install cheerio semver && \ + node ./download-apprise.mjs + +# Base Image (Slim) # If the image changed, the second stage image should be changed too FROM node:20-bookworm-slim AS base2-slim ARG TARGETPLATFORM @@ -27,8 +37,9 @@ RUN apt update && \ # apprise = for notifications (Install from the deb package, as the stable one is too old) (workaround for #4867) # Switching to testing repo is no longer working, as the testing repo is not bookworm anymore. # python3-paho-mqtt (#4859) -RUN curl http://ftp.debian.org/debian/pool/main/a/apprise/apprise_1.8.0-2_all.deb --output apprise.deb && \ - apt update && \ +# TODO: no idea how to delete the deb file after installation as it becomes a layer already +COPY --from=download-apprise /app/apprise.deb ./apprise.deb +RUN apt update && \ apt --yes --no-install-recommends install ./apprise.deb python3-paho-mqtt && \ rm -rf /var/lib/apt/lists/* && \ rm -f apprise.deb && \ diff --git a/extra/download-apprise.mjs b/extra/download-apprise.mjs new file mode 100644 index 00000000..3d31f7cf --- /dev/null +++ b/extra/download-apprise.mjs @@ -0,0 +1,57 @@ +// Go to http://ftp.debian.org/debian/pool/main/a/apprise/ using fetch api, where it is a apache directory listing page +// Use cheerio to parse the html and get the latest version of Apprise +// call curl to download the latest version of Apprise +// Target file: the latest version of Apprise, which the format is apprise_{VERSION}_all.deb + +import * as cheerio from "cheerio"; +import semver from "semver"; +import * as childProcess from "child_process"; + +const baseURL = "http://ftp.debian.org/debian/pool/main/a/apprise/"; +const response = await fetch(baseURL); + +if (!response.ok) { + throw new Error("Failed to fetch page of Apprise Debian repository."); +} + +const html = await response.text(); + +const $ = cheerio.load(html); + +// Get all the links in the page +const linkElements = $("a"); + +// Filter the links which match apprise_{VERSION}_all.deb +const links = []; +const pattern = /apprise_(.*?)_all.deb/; + +for (let i = 0; i < linkElements.length; i++) { + const link = linkElements[i]; + if (link.attribs.href.match(pattern) && !link.attribs.href.includes("~")) { + links.push({ + filename: link.attribs.href, + version: link.attribs.href.match(pattern)[1], + }); + } +} + +console.log(links); + +// semver compare and download +let latestLink = { + filename: "", + version: "0.0.0", +}; + +for (const link of links) { + if (semver.gt(link.version, latestLink.version)) { + latestLink = link; + } +} + +const downloadURL = baseURL + latestLink.filename; +console.log(`Downloading ${downloadURL}...`); +let result = childProcess.spawnSync("curl", [ downloadURL, "--output", "apprise.deb" ]); +console.log(result.stdout?.toString()); +console.error(result.stderr?.toString()); +process.exit(result.status !== null ? result.status : 1);