Fix `encodeBase64` for empty password or user in HTTP Basic Authentication (#4326)

pull/4399/head
Adam Stachowicz 10 months ago committed by GitHub
parent f1e2ee74ea
commit 458cdf9f9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -230,10 +230,12 @@ class Monitor extends BeanModel {
/**
* Encode user and password to Base64 encoding
* for HTTP "basic" auth, as per RFC-7617
* @param {string|null} user - The username (nullable if not changed by a user)
* @param {string|null} pass - The password (nullable if not changed by a user)
* @returns {string}
*/
encodeBase64(user, pass) {
return Buffer.from(user + ":" + pass).toString("base64");
return Buffer.from(`${user || ""}:${pass || ""}`).toString("base64");
}
/**

Loading…
Cancel
Save