From 4f07c2ea9a61df2145c3bd2cc32fbb1af16a6557 Mon Sep 17 00:00:00 2001
From: LouisLam <louislam@users.noreply.github.com>
Date: Thu, 9 Sep 2021 15:46:28 +0800
Subject: [PATCH] uptime calculation fully sum in sql

---
 server/model/monitor.js | 81 ++++++++++++++++++-----------------------
 1 file changed, 36 insertions(+), 45 deletions(-)

diff --git a/server/model/monitor.js b/server/model/monitor.js
index cc9ab454..9562041d 100644
--- a/server/model/monitor.js
+++ b/server/model/monitor.js
@@ -409,59 +409,50 @@ class Monitor extends BeanModel {
     static async sendUptime(duration, io, monitorID, userID) {
         const timeLogger = new TimeLogger();
 
-        let sec = duration * 3600;
-
-        let heartbeatList = await R.getAll(`
-            SELECT duration, time, status
+        const startTime = R.isoDateTime(dayjs.utc().subtract(duration, "hour"));
+
+        // Handle if heartbeat duration longer than the target duration
+        // e.g. If the last beat's duration is bigger that the 24hrs window, it will use the duration between the (beat time - window margin) (THEN case in SQL)
+        let result = await R.getRow(`
+            SELECT
+               -- SUM all duration, also trim off the beat out of time window
+                SUM(
+                    CASE
+                        WHEN (JULIANDAY(\`time\`) - JULIANDAY(?)) * 86400 < duration
+                        THEN (JULIANDAY(\`time\`) - JULIANDAY(?)) * 86400
+                        ELSE duration
+                    END
+                ) AS total_duration,
+
+               -- SUM all uptime duration, also trim off the beat out of time window
+                SUM(
+                    CASE
+                        WHEN (status = 1)
+                        THEN
+                            CASE
+                                WHEN (JULIANDAY(\`time\`) - JULIANDAY(?)) * 86400 < duration
+                                    THEN (JULIANDAY(\`time\`) - JULIANDAY(?)) * 86400
+                                ELSE duration
+                            END
+                        END
+                ) AS uptime_duration
             FROM heartbeat
-            WHERE time > DATETIME('now', ? || ' hours')
-            AND monitor_id = ? `, [
-            -duration,
+            WHERE time > ?
+            AND monitor_id = ?
+        `, [
+            startTime, startTime, startTime, startTime, startTime,
             monitorID,
         ]);
 
         timeLogger.print(`[Monitor: ${monitorID}][${duration}] sendUptime`);
 
-        let downtime = 0;
-        let total = 0;
-        let uptime;
-
-        // Special handle for the first heartbeat only
-        if (heartbeatList.length === 1) {
-
-            if (heartbeatList[0].status === 1) {
-                uptime = 1;
-            } else {
-                uptime = 0;
-            }
-
-        } else {
-            for (let row of heartbeatList) {
-                let value = parseInt(row.duration)
-                let time = row.time
-
-                // Handle if heartbeat duration longer than the target duration
-                // e.g.   Heartbeat duration = 28hrs, but target duration = 24hrs
-                if (value > sec) {
-                    let trim = dayjs.utc().diff(dayjs(time), "second");
-                    value = sec - trim;
-
-                    if (value < 0) {
-                        value = 0;
-                    }
-                }
-
-                total += value;
-                if (row.status === 0 || row.status === 2) {
-                    downtime += value;
-                }
-            }
+        let totalDuration = result.total_duration;
+        let uptimeDuration = result.uptime_duration;
 
-            uptime = (total - downtime) / total;
+        let uptime = uptimeDuration / totalDuration;
 
-            if (uptime < 0) {
-                uptime = 0;
-            }
+        if (uptime < 0) {
+            uptime = 0;
         }
 
         io.to(userID).emit("uptime", monitorID, duration, uptime);