Apply suggestions from code review

Co-authored-by: Frank Elsinga <frank@elsinga.de>

server/notification-providers/gtx-messaging.js

@@ -17,8 +17,8 @@ class GtxMessaging extends NotificationProvider {
 
         try {
             const data = new URLSearchParams();
-            data.append("from", from);
-            data.append("to", to);
+            data.append("from", notification.gtxMessagingFrom.trim());
+            data.append("to", notification.gtxMessagingTo.trim());
             data.append("text", text);
 
             const url = `https://rest.gtx-messaging.net/smsc/sendsms/${notification.gtxMessagingApiKey}/json`;

src/components/notifications/GtxMessaging.vue

@@ -1,6 +1,6 @@
 <template>
     <div class="mb-3">
-        <label for="gtxmessaging-api-key" class="form-label">{{ $t("gtxMessagingApiKey") }}</label>
+        <label for="gtxmessaging-api-key" class="form-label">{{ $t("API Key") }}</label>
         <HiddenInput id="gtxmessaging-api-key" v-model="$parent.notification.gtxMessagingApiKey" :required="true"></HiddenInput>
         <div class="form-text">
             {{ $t("gtxMessagingApiKeyHint") }}

src/lang/en.json

@@ -884,7 +884,6 @@
     "GrafanaOncallUrl": "Grafana Oncall URL",
     "Browser Screenshot": "Browser Screenshot",
     "What is a Remote Browser?": "What is a Remote Browser?",
-    "gtxMessagingApiKey": "API Key",
     "gtxMessagingApiKeyHint": "You can find your API key at: My Routing Accounts > Show Account Information > API Credentials > REST API (v2.x)",
     "gtxMessagingFrom": "The originator of the message.",
     "gtxMessagingFromHint": "Allowed is alphanumeric up to 11 chars, shortcode, local longcode or international number (E.164, E.212 or E.214).",