From d552975d6c35daebf44946a00b94a7c9500ae6e7 Mon Sep 17 00:00:00 2001
From: Suven-p <pandeysuven@gmail.com>
Date: Mon, 28 Oct 2024 07:01:07 +0545
Subject: [PATCH] Display toast on invalid query params

---
 src/components/MonitorList.vue       | 14 ++++++++++---
 src/components/MonitorListFilter.vue | 31 ++++++++++++++++++++++++----
 src/lang/en.json                     |  3 ++-
 3 files changed, 40 insertions(+), 8 deletions(-)

diff --git a/src/components/MonitorList.vue b/src/components/MonitorList.vue
index 272421e02..8b85b9762 100644
--- a/src/components/MonitorList.vue
+++ b/src/components/MonitorList.vue
@@ -160,7 +160,7 @@ export default {
 
         /**
          * Returns applied filters based on query params.
-         * @returns {{ status: number[], active: bool, tags: number[] }} The current filter state.
+         * @returns {{ status: number[], active: any[], tags: number[] }} The current filter state.
          */
         filterState() {
             // Since query params are always strings, convert them to the correct type
@@ -174,7 +174,15 @@ export default {
             if (!Array.isArray(active)) {
                 active = [ active ];
             }
-            active = active.map(val => val === "true");
+            active = active.map(val => {
+                if (val === "true") {
+                    return true;
+                }
+                if (val === "false") {
+                    return false;
+                }
+                return val;
+            });
             let tags = this.$route.query["tags"] || [];
             if (!Array.isArray(tags)) {
                 tags = [ tags ];
@@ -279,7 +287,7 @@ export default {
         },
         /**
          * Update the MonitorList Filter
-         * @param {{ status: number[], active: bool, tags: number[] }} newFilter Object with new filter
+         * @param {{ status: number[], active: any[], tags: number[] }} newFilter Object with new filter
          * @returns {void}
          */
         updateFilter(newFilter) {
diff --git a/src/components/MonitorListFilter.vue b/src/components/MonitorListFilter.vue
index 930c6ea7a..251551006 100644
--- a/src/components/MonitorListFilter.vue
+++ b/src/components/MonitorListFilter.vue
@@ -80,8 +80,9 @@
         <MonitorListFilterDropdown :filterActive="filterState.active?.length > 0">
             <template #status>
                 <span v-if="filterState.active?.length === 1">
-                    <span v-if="filterState.active[0]">{{ $t("Running") }}</span>
-                    <span v-else>{{ $t("filterActivePaused") }}</span>
+                    <span v-if="filterState.active[0] === true">{{ $t("Running") }}</span>
+                    <span v-else-if="filterState.active[0] === false">{{ $t("filterActivePaused") }}</span>
+                    <span v-else>{{ $t("Unknown") }}</span>
                 </span>
                 <span v-else>
                     {{ $t("filterActive") }}
@@ -186,10 +187,31 @@ export default {
             });
 
             return num;
+        },
+        /**
+         * Returns an array of invalid filters assuming tagsList has been fetched
+         * @returns {Array} Array of invalid filters
+         */
+        invalidFilters() {
+            const filters = [];
+            if (!this.filterState.status.every((val) => val >= 0 && val <= 3)) {
+                filters.push(this.$t("Status"));
+            }
+            if (!this.filterState.active.every((val) => val === true || val === false)) {
+                filters.push(this.$t("Active"));
+            }
+            if (!this.filterState.tags.every((val) => this.tagsList.find(tag => tag.id === val))) {
+                filters.push(this.$t("Tags"));
+            }
+            return filters;
         }
     },
     mounted() {
-        this.getExistingTags();
+        this.getExistingTags(() => {
+            if (this.invalidFilters.length > 0) {
+                this.$root.toastError(this.$t("InvalidFilters", [ this.invalidFilters.join(", ") ]));
+            }
+        });
     },
     methods: {
         toggleStatusFilter(status) {
@@ -245,11 +267,12 @@ export default {
                 status: [],
             });
         },
-        getExistingTags() {
+        getExistingTags(callback) {
             this.$root.getSocket().emit("getTags", (res) => {
                 if (res.ok) {
                     this.tagsList = res.tags;
                 }
+                callback();
             });
         },
         getTaggedMonitorCount(tag) {
diff --git a/src/lang/en.json b/src/lang/en.json
index 07d3a3d24..9e28ed0f6 100644
--- a/src/lang/en.json
+++ b/src/lang/en.json
@@ -1060,5 +1060,6 @@
     "RabbitMQ Password": "RabbitMQ Password",
     "rabbitmqHelpText": "To use the monitor, you will need to enable the Management Plugin in your RabbitMQ setup. For more information, please consult the {rabitmq_documentation}.",
     "SendGrid API Key": "SendGrid API Key",
-    "Separate multiple email addresses with commas": "Separate multiple email addresses with commas"
+    "Separate multiple email addresses with commas": "Separate multiple email addresses with commas",
+    "InvalidFilters": "The following filters are invalid: {0}"
 }