Frank Elsinga
0e3b3a9ab8
Made sure that more of the async usages are awaited ( #4574 )
10 months ago
Frank Elsinga
a9a1cf1353
Chore: General notification reformatting ( #3182 )
...
- I unified where in file the name of `NotificationProvider.name` is placed
- I made sure that all the providers adhere to the signature of `NotificationProvider.send()`
- I made sure that all the providers use `okMsg` if returning success messages directly from the function.
Here a discussion should be had:
Should this be refactored into a constant of `NotificationProvider`? I could imagine that `NotificationProvider.SENDING_SUCCESSFULL` could be a suitable alternative.
- I made sure all providers have the URL they `POST`/`GET` to be extraced into a variable.
=> refactored this way due to Nelsons suggestion
10 months ago
Louis Lam
31c00081fa
Merge branch 'master' into 2.0.X
1 year ago
zhenqiang
c0174dc1c4
fix(notification-aliyun-sms): throw error when sending SMS failed ( #3573 )
1 year ago
Matthew Nickson
8a92054c2b
Added JSDoc to ESLint ( #3529 )
...
* Added JSDoc to eslint rules
Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>
* Fixed JSDoc eslint errors
Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>
* Update the check-linters workflow to Node.js 20
---------
Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>
Co-authored-by: Louis Lam <louislam@users.noreply.github.com>
1 year ago
Louis Lam
53b98ad3e4
Add more comment for aliyun-sms fix
3 years ago
GOGOsu
73e38a13d2
Update server/notification-providers/aliyun-sms.js
...
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
3 years ago
GOGOsu
369477b4b9
Update aliyun-sms.js
3 years ago
GOGOsu
2347a01f7c
Update aliyun-sms.js
...
Add comments for the changed code.
3 years ago
GOGOsu
ae2c49a729
Update aliyun-sms.js
3 years ago
GOGOsu
b9e72b9645
Update aliyun-sms.js
...
aliyun-sms.js: escape more characters than encodeURIComponent
see https://help.aliyun.com/document_detail/315526.html
字符A~Z、a~z、0~9以及字符-、_、.、~不编码。对其它ASCII码字符进行编码。
3 years ago
Matthew Nickson
6d22ebedca
Merge branch 'master' into add-JSDoc-comments
3 years ago
Louis Lam
47c72192e1
[eslint] Enable yoda and eqeqeq
3 years ago
Matthew Nickson
5a209c74e1
Add JSDoc to server/notification-providers/*
...
Signed-off-by: Matthew Nickson <mnickson@sidingsmedia.com>
3 years ago
Louis Lam
f51156f18e
run eslint for #687
3 years ago
wuwenjing
57a76e6129
remove `alicloud/pop-core` keep simple
3 years ago
wuwenjing
a2f2253221
Add aliyun sms notification
3 years ago