From a68e3e426efcf3f9c3b0ff0c41d2b063199c7408 Mon Sep 17 00:00:00 2001
From: cupcakearmy <hi@nicco.io>
Date: Sun, 31 Oct 2021 23:07:12 +0100
Subject: [PATCH] simplify options handling

---
 internal/config.go   | 13 +++++++++++++
 internal/location.go | 10 ++--------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/internal/config.go b/internal/config.go
index dce9331..be7118d 100644
--- a/internal/config.go
+++ b/internal/config.go
@@ -55,6 +55,7 @@ func GetConfig() *Config {
 
 			config = &Config{}
 			if err := viper.UnmarshalExact(config); err != nil {
+				colors.Error.Println(err)
 				colors.Error.Println("Could not parse config file!")
 				lock.Unlock()
 				os.Exit(1)
@@ -273,3 +274,15 @@ func getOptions(options Options, key string) []string {
 	}
 	return selected
 }
+
+func combineOptions(key string, l Location, b Backend) []string {
+	// Priority: location > backend > global
+	var options []string
+	gFlags := getOptions(GetConfig().Global, key)
+	bFlags := getOptions(b.Options, key)
+	lFlags := getOptions(l.Options, key)
+	options = append(options, gFlags...)
+	options = append(options, bFlags...)
+	options = append(options, lFlags...)
+	return options
+}
diff --git a/internal/location.go b/internal/location.go
index 0151802..024252e 100644
--- a/internal/location.go
+++ b/internal/location.go
@@ -184,11 +184,8 @@ func (l Location) Backup(cron bool, specificBackend string) []error {
 			continue
 		}
 
-		lFlags := getOptions(l.Options, "backup")
-		bFlags := getOptions(backend.Options, "backup")
 		cmd := []string{"backup"}
-		cmd = append(cmd, lFlags...)
-		cmd = append(cmd, bFlags...)
+		cmd = append(cmd, combineOptions("backup", l, backend)...)
 		if cron {
 			cmd = append(cmd, "--tag", l.getTag("cron"))
 		}
@@ -269,8 +266,6 @@ func (l Location) Forget(prune bool, dry bool) error {
 		options := ExecuteOptions{
 			Envs: env,
 		}
-		lFlags := getOptions(l.Options, "forget")
-		bFlags := getOptions(backend.Options, "forget")
 		cmd := []string{"forget", "--tag", l.getLocationTag()}
 		if prune {
 			cmd = append(cmd, "--prune")
@@ -278,8 +273,7 @@ func (l Location) Forget(prune bool, dry bool) error {
 		if dry {
 			cmd = append(cmd, "--dry-run")
 		}
-		cmd = append(cmd, lFlags...)
-		cmd = append(cmd, bFlags...)
+		cmd = append(cmd, combineOptions("forget", l, backend)...)
 		out, err := ExecuteResticCommand(options, cmd...)
 		if VERBOSE {
 			colors.Faint.Println(out)