Custom browser endpoints should not have a proxy set

fix-prefer-fetch
dgtlmoon 10 months ago
parent d2569ba715
commit 238b909c0b

@ -75,12 +75,12 @@ class difference_detection_processor():
proxy_url = None proxy_url = None
if preferred_proxy_id: if preferred_proxy_id:
# Custom browser endpoints should not have a proxy added # Custom browser endpoints should NOT have a proxy added
if not preferred_proxy_id.startswith('ui-'): if not prefer_fetch_backend.startswith('extra_browser_'):
proxy_url = self.datastore.proxy_list.get(preferred_proxy_id).get('url') proxy_url = self.datastore.proxy_list.get(preferred_proxy_id).get('url')
logger.debug(f"Selected proxy key '{preferred_proxy_id}' as proxy URL '{proxy_url}' for {url}") logger.debug(f"Selected proxy key '{preferred_proxy_id}' as proxy URL '{proxy_url}' for {url}")
else: else:
logger.debug(f"Skipping adding proxy data when custom Browser endpoint is specified.") logger.debug(f"Skipping adding proxy data when custom Browser endpoint is specified. ")
# Now call the fetcher (playwright/requests/etc) with arguments that only a fetcher would need. # Now call the fetcher (playwright/requests/etc) with arguments that only a fetcher would need.
# When browser_connection_url is None, it method should default to working out whats the best defaults (os env vars etc) # When browser_connection_url is None, it method should default to working out whats the best defaults (os env vars etc)

Loading…
Cancel
Save