Re #1365 - Playwright - Browser "Service Workers" should be enabled by default but unset via env var PLAYWRIGHT_SERVICE_WORKERS=block (#1367)

pull/1379/head
dgtlmoon 2 years ago committed by GitHub
parent 0ed897c50f
commit 41856c4ed8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -297,8 +297,8 @@ class base_html_playwright(Fetcher):
proxy=self.proxy, proxy=self.proxy,
# This is needed to enable JavaScript execution on GitHub and others # This is needed to enable JavaScript execution on GitHub and others
bypass_csp=True, bypass_csp=True,
# Can't think why we need the service workers for our use case? # Should be `allow` or `block` - sites like YouTube can transmit large amounts of data via Service Workers
service_workers='block', service_workers=os.getenv('PLAYWRIGHT_SERVICE_WORKERS', 'allow'),
# Should never be needed # Should never be needed
accept_downloads=False accept_downloads=False
) )

Loading…
Cancel
Save