PDF Fetcher for change detection - Always use plain requests for PDF because otherwise we cant access the embed PDF in the browser (#2020)

pull/2018/head
dgtlmoon 1 year ago committed by GitHub
parent 156d403552
commit 599291645d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -52,6 +52,11 @@ class difference_detection_processor():
prefer_fetch_backend = 'base_html_playwright' prefer_fetch_backend = 'base_html_playwright'
browser_connection_url = connection[0].get('browser_connection_url') browser_connection_url = connection[0].get('browser_connection_url')
# PDF should be html_requests because playwright will serve it up (so far) in a embedded page
# @todo https://github.com/dgtlmoon/changedetection.io/issues/2019
# @todo needs test to or a fix
if self.watch.is_pdf:
prefer_fetch_backend = "html_requests"
# Grab the right kind of 'fetcher', (playwright, requests, etc) # Grab the right kind of 'fetcher', (playwright, requests, etc)
if hasattr(content_fetcher, prefer_fetch_backend): if hasattr(content_fetcher, prefer_fetch_backend):

Loading…
Cancel
Save