UI - Fix wrong logic when dealing with webdriver/playwright watch screenshot settings (#1325)

pull/1329/head
dgtlmoon 2 years ago committed by GitHub
parent fba719ab8d
commit 7048a0acbd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -652,7 +652,7 @@ def changedetection_app(config=None, datastore_o=None):
system_uses_webdriver = datastore.data['settings']['application']['fetch_backend'] == 'html_webdriver'
is_html_webdriver = False
if (watch.get('fetch_backend') == 'system' and system_uses_webdriver) or watch.get('fetch_backend') == 'html_requests':
if (watch.get('fetch_backend') == 'system' and system_uses_webdriver) or watch.get('fetch_backend') == 'html_webdriver':
is_html_webdriver = True
output = render_template("edit.html",

@ -52,3 +52,12 @@ def test_visual_selector_content_ready(client, live_server):
# Open it and see if it roughly looks correct
with open(os.path.join('test-datastore', uuid, 'elements.json'), 'r') as f:
json.load(f)
# Some options should be enabled
# @todo - in the future, the visibility should be toggled by JS from the request type setting
res = client.get(
url_for("edit_page", uuid="first"),
follow_redirects=True
)
assert b'notification_screenshot' in res.data

Loading…
Cancel
Save