Docker & python - Use pip conditional requirements to not install playwright for ARM (unsupported on ARM) (#1067)

Dockerfile

@@ -21,12 +21,6 @@ COPY requirements.txt /requirements.txt
 
 RUN pip install --target=/dependencies -r /requirements.txt
 
-# Playwright is an alternative to Selenium
-# Excluded this package from requirements.txt to prevent arm/v6 and arm/v7 builds from failing
-RUN pip install --target=/dependencies playwright~=1.26 \
-    || echo "WARN: Failed to install Playwright. The application can still run, but the Playwright option will be disabled."
-
-
 RUN pip install --target=/dependencies jq~=1.3 \
     || echo "WARN: Failed to install JQ. The application can still run, but the Jq: filter option will be disabled."
 

changedetectionio/run_all_tests.sh

@@ -46,10 +46,6 @@ unset WEBDRIVER_URL
 docker kill $$-test_selenium
 
 echo "TESTING WEBDRIVER FETCH > PLAYWRIGHT/BROWSERLESS..."
-# Not all platforms support playwright (not ARM/rPI), so it's not packaged in requirements.txt
-PLAYWRIGHT_VERSION=$(grep -i -E "RUN pip install.+" "$SCRIPT_DIR/../Dockerfile" | grep --only-matching -i -E "playwright[=><~+]+[0-9\.]+")
-echo "using $PLAYWRIGHT_VERSION"
-pip3 install "$PLAYWRIGHT_VERSION"
 docker run -d --name $$-test_browserless -e "DEFAULT_LAUNCH_ARGS=[\"--window-size=1920,1080\"]" --rm  -p 3000:3000  --shm-size="2g"  browserless/chrome:1.53-chrome-stable
 # takes a while to spin up
 sleep 5

requirements.txt

@@ -50,5 +50,6 @@ werkzeug ~= 2.0.0
 jinja2~=3.1
 jinja2-time
 
-# playwright is installed at Dockerfile build time because it's not available on all platforms
+playwright~=1.26; python_version >= "3.8" and "arm" not in platform_machine and "aarch" not in platform_machine
+