|
|
|
@ -27,20 +27,16 @@ The frontend code build into "dist" directory. The server (express.js) exposes t
|
|
|
|
|
|
|
|
|
|
|
|
## Can I create a pull request for Uptime Kuma?
|
|
|
|
## Can I create a pull request for Uptime Kuma?
|
|
|
|
|
|
|
|
|
|
|
|
⚠️ 2022-03-02 Update:
|
|
|
|
(Updated 2022-04-24) Since I don't want to waste your time, be sure to create empty draft pull request, so we can discuss first.
|
|
|
|
|
|
|
|
|
|
|
|
Since I found that merging pull requests is a pretty heavy task for me, I try to rearrange it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
✅ Accept:
|
|
|
|
✅ Accept:
|
|
|
|
- Bug/Security fix
|
|
|
|
- Bug/Security fix
|
|
|
|
- Translations
|
|
|
|
- Translations
|
|
|
|
- Adding notification providers
|
|
|
|
- Adding notification providers
|
|
|
|
|
|
|
|
|
|
|
|
❌ Avoid:
|
|
|
|
⚠️ Discuss First
|
|
|
|
- Large pull requests
|
|
|
|
- Large pull requests
|
|
|
|
- New big features
|
|
|
|
- New features
|
|
|
|
|
|
|
|
|
|
|
|
My long story here: https://www.reddit.com/r/UptimeKuma/comments/t1t6or/comment/hynyijx/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
### Recommended Pull Request Guideline
|
|
|
|
### Recommended Pull Request Guideline
|
|
|
|
|
|
|
|
|
|
|
|
|
Louis Lam
3 years ago