Validate cron before submit

pull/2743/merge
Louis Lam 2 years ago
parent 511038b45a
commit dbfaddafca

@ -164,6 +164,7 @@ class Maintenance extends BeanModel {
if (bean.strategy === "cron") { if (bean.strategy === "cron") {
bean.duration = obj.durationMinutes * 60; bean.duration = obj.durationMinutes * 60;
bean.cron = obj.cron; bean.cron = obj.cron;
this.validateCron(bean.cron);
} }
if (bean.strategy.startsWith("recurring-")) { if (bean.strategy.startsWith("recurring-")) {
@ -172,11 +173,21 @@ class Maintenance extends BeanModel {
bean.weekdays = JSON.stringify(obj.weekdays); bean.weekdays = JSON.stringify(obj.weekdays);
bean.days_of_month = JSON.stringify(obj.daysOfMonth); bean.days_of_month = JSON.stringify(obj.daysOfMonth);
await bean.generateCron(); await bean.generateCron();
this.validateCron(bean.cron);
} }
return bean; return bean;
} }
/**
* Throw error if cron is invalid
* @param cron
* @returns {Promise<void>}
*/
static async validateCron(cron) {
let job = new Cron(cron, () => {});
job.stop();
}
/** /**
* Run the cron * Run the cron
*/ */

Loading…
Cancel
Save