Matt Visnovsky
da8f0d1c31
Apply suggestions from code review
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
8 months ago
Matt Visnovsky
2b5d100cd3
Ensure SNMP session is closed properly
...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589858252
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
8 months ago
Matt Visnovsky
e9b52eb0e7
Separate error cases for SNMP varbind returns
8 months ago
Matt Visnovsky
c68b1c6274
Remove unnecessary func getKey
8 months ago
Matt Visnovsky
433e317eee
Simplify error catch
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
8 months ago
Matt Visnovsky
1fe1bb5864
Given that above throws, the else case is not nessesary
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
8 months ago
Matt Visnovsky
997791bc78
Default: invalid condition error
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
8 months ago
Matt Visnovsky
0384b34007
Remove unnecessary func getKey
...
Addresses:
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589856311
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589862733
8 months ago
Matt Visnovsky
0280b2ad3f
A comment about varbinds[0] for clarification
...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589855126
8 months ago
Matt Visnovsky
4386d0afad
Apply suggestions from code review
...
Addresses:
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589805237
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589806199
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589853470
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589854032
8 months ago
Matt Visnovsky
09fd816aae
Updated code comments
8 months ago
Matt Visnovsky
c87ac2f043
Move getKey() to util.ts
8 months ago
Matt Visnovsky
8e56a81ef1
Refactor how strings/numerics are parsed
...
Fixes issue `toString() radix argument must be between 2 and 36` due to `.toString("ascii")` conversion. This issue was introduced in 704ffd3f4b
.
8 months ago
Matt Visnovsky
f059d54349
Use frontend timeout
...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1585616669
8 months ago
Matt Visnovsky
9ba0f68a86
Remove supurfluous log.debug
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
8 months ago
Matt Visnovsky
7459654e11
ES Lint Compliant
8 months ago
Matt Visnovsky
ba47aca51f
Apply suggestions from code review
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
8 months ago
Frank Elsinga
b4bd003626
Merge branch 'master' into snmp-monitor
8 months ago
Matt Visnovsky
704ffd3f4b
Finalized SNMP monitor
8 months ago
Matt Visnovsky
9d28fcff1a
Update bean model backend
...
Updates appropriate values async when editing the SNMP monitor
8 months ago
Ezhil Shanmugham
988ba79679
feat: keephq notification provider ( #4722 )
8 months ago
Matt Visnovsky
99dc4cfb46
Wrong variable used
...
Thanks for pointing it out @CommanderStorm!
8 months ago
Matt Visnovsky
4a882be6ba
Further SNMP monitor development
...
Further testing of SNMP feat, however I'm running into the issue `Error in SNMP check: RequestTimedOutError: Request timed out` when the check function is called. I am unsure as to why since my local SNMP script works great with very similar code.
8 months ago
Matt Visnovsky
a3cdd69995
Use net-snmp instead of snmp-native
...
net-snmp over snmp-native is:
-more robust
-more popular
-better documented
-supports v3
8 months ago
Joschua Becker
19e8c75c3b
SevenIO Notification Provider ( #4219 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
8 months ago
凯观生活
126d6cd912
Add the ability to notify `@everyone` in DingTalk notifications ( #4718 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
8 months ago
Matt Visnovsky
d92003e172
SNMP Initial Commits
...
This commit introduces a new SNMP monitor feature to the application, allowing users to monitor devices using SNMP (Simple Network Management Protocol).
8 months ago
Louis Lam
1d091739c8
Update server/model/monitor.js
...
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
8 months ago
Louis Lam
27bcc968ec
Update server/util-server.js
...
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
8 months ago
Louis Lam
c0db036187
Update server/model/monitor.js
...
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
8 months ago
Louis Lam
63a380326d
Merge branch '1.23.X' into 1.23.13-to-2.0.0
...
# Conflicts:
# .github/workflows/auto-test.yml
# package-lock.json
# package.json
# server/database.js
# server/model/monitor.js
# server/monitor-types/real-browser-monitor-type.js
# server/util-server.js
# test/cypress/unit/i18n.spec.js
8 months ago
Nelson Chan
1490443618
Fix: Getting TLS certificate through proxy & prometheus update ( #4700 )
8 months ago
BigBoot
bab427f715
Add `loginRequired` SocketIO event ( #4636 )
8 months ago
Louis Lam
7a9e2f5de6
Merge pull request from GHSA-23q2-5gf8-gjpp
8 months ago
CoolCu
b25ac55a2f
chore: fix some typos in comments ( #4679 )
...
Signed-off-by: CoolCu <coolcui@qq.com>
9 months ago
Nelson Chan
893278bd3d
Feat: Use keylog event to obtain TLS certificate for better reliability [1.23.X] ( #4630 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
Edoardo Ridolfi
822ce5384b
Add support for Whapi notification provider ( #4323 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
Merlin
937c8a9a7b
New notification provider: CallMeBot API ( #4605 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
Daan Meijer
effd0197ac
[Slack] restructure alert actions, add 'visit site' button ( #3886 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Nelson Chan <3271800+chakflying@users.noreply.github.com>
9 months ago
Nelson Chan
ee7f8680c1
Fix: Add missing FK for monitor-tls-info table [1.23.X] ( #4631 )
9 months ago
Nelson Chan
08f75b0b99
Fix: Add missing FK for monitor-tls-info table ( #4632 )
9 months ago
Simon Nilsson
0923d05317
Cellsynt mobile services ( #4625 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
Nelson Chan
b8858f4605
Feat: Handle maintenance in `UptimeCalculator` ( #4406 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
Christoph Fichtmüller
49b6dacb4d
Add gtxmessaging Notification Support ( #4481 )
...
Signed-off-by: Christoph Fichtmüller <cf@cfichtmueller.com>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
Louis Lam
e927327bad
Some minor changes for 2.0.0 ( #4621 )
9 months ago
Elliot Matson
5bc68fe0a7
Google chat cards ( #3928 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
9 months ago
OptimusGREEN
bc077cc536
add notification channel for home assistant ( #4541 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Seb <144435+rmtsrc@users.noreply.github.com>
10 months ago
Frank Elsinga
975761b448
made sure to use `Promise.allSettled` instead of sleeping for 500ms after login ( #4592 )
10 months ago
Frank Elsinga
0e3b3a9ab8
Made sure that more of the async usages are awaited ( #4574 )
10 months ago
Frank Elsinga
a9a1cf1353
Chore: General notification reformatting ( #3182 )
...
- I unified where in file the name of `NotificationProvider.name` is placed
- I made sure that all the providers adhere to the signature of `NotificationProvider.send()`
- I made sure that all the providers use `okMsg` if returning success messages directly from the function.
Here a discussion should be had:
Should this be refactored into a constant of `NotificationProvider`? I could imagine that `NotificationProvider.SENDING_SUCCESSFULL` could be a suitable alternative.
- I made sure all providers have the URL they `POST`/`GET` to be extraced into a variable.
=> refactored this way due to Nelsons suggestion
10 months ago