Improve ARM/rust build comment

pull/1228/head
dgtlmoon 2 years ago
parent 6c217cc3b6
commit 6562d6e0d4

@ -1,7 +1,7 @@
# pip dependencies install stage # pip dependencies install stage
FROM python:3.8-slim as builder FROM python:3.8-slim as builder
# rustc compiler would be needed on ARM type devices but theres an issue with some deps not building.. # See `cryptography` pin comment in requirements.txt
ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1 ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1
RUN apt-get update && apt-get install -y --no-install-recommends \ RUN apt-get update && apt-get install -y --no-install-recommends \
@ -31,8 +31,7 @@ RUN pip install --target=/dependencies playwright~=1.27.1 \
# Final image stage # Final image stage
FROM python:3.8-slim FROM python:3.8-slim
# Actual packages needed at runtime, usually due to the notification (apprise) backend # See `cryptography` pin comment in requirements.txt
# rustc compiler would be needed on ARM type devices but theres an issue with some deps not building..
ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1 ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1
# Re #93, #73, excluding rustc (adds another 430Mb~) # Re #93, #73, excluding rustc (adds another 430Mb~)

@ -29,8 +29,9 @@ apprise~=1.2.0
# apprise mqtt https://github.com/dgtlmoon/changedetection.io/issues/315 # apprise mqtt https://github.com/dgtlmoon/changedetection.io/issues/315
paho-mqtt paho-mqtt
# Pinned version of cryptography otherwise # This mainly affects some ARM builds, which unlike the other builds ignores "ARG CRYPTOGRAPHY_DONT_BUILD_RUST=1"
# ERROR: Could not build wheels for cryptography which use PEP 517 and cannot be installed directly # so without this pinning, the newer versions on ARM will forcefully try to build rust, which results in "rust compiler not found"
# (introduced once apprise became a dep)
cryptography~=3.4 cryptography~=3.4
# Used for CSS filtering # Used for CSS filtering

Loading…
Cancel
Save